minihippo commented on code in PR #5064:
URL: https://github.com/apache/hudi/pull/5064#discussion_r963929042
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -2124,7 +2124,7 @@ public HoodieStorageLayout.LayoutType getLayoutType() {
* Metastore configs.
*/
public boolean isMetastoreEnabled() {
Review Comment:
fix
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetaServerConfig.java:
##########
@@ -28,65 +28,65 @@
@ConfigClassProperty(name = "Metastore Configs",
groupName = ConfigGroups.Names.WRITE_CLIENT,
description = "Configurations used by the Hudi Metastore.")
-public class HoodieMetastoreConfig extends HoodieConfig {
+public class HoodieMetaServerConfig extends HoodieConfig {
- public static final String METASTORE_PREFIX = "hoodie.metastore";
+ public static final String META_SERVER_PREFIX = "hoodie.metaserver";
- public static final ConfigProperty<Boolean> METASTORE_ENABLE = ConfigProperty
- .key(METASTORE_PREFIX + ".enable")
+ public static final ConfigProperty<Boolean> META_SERVER_ENABLE =
ConfigProperty
+ .key(META_SERVER_PREFIX + ".enable")
.defaultValue(false)
.withDocumentation("Use metastore server to store hoodie table
metadata");
- public static final ConfigProperty<String> METASTORE_URLS = ConfigProperty
- .key(METASTORE_PREFIX + ".uris")
+ public static final ConfigProperty<String> META_SERVER_URLS = ConfigProperty
+ .key(META_SERVER_PREFIX + ".uris")
.defaultValue("thrift://localhost:9090")
.withDocumentation("Metastore server uris");
- public static final ConfigProperty<Integer> METASTORE_CONNECTION_RETRIES =
ConfigProperty
- .key(METASTORE_PREFIX + ".connect.retries")
+ public static final ConfigProperty<Integer> META_SERVER_CONNECTION_RETRIES =
ConfigProperty
+ .key(META_SERVER_PREFIX + ".connect.retries")
.defaultValue(3)
.withDocumentation("Number of retries while opening a connection to
metastore");
- public static final ConfigProperty<Integer> METASTORE_CONNECTION_RETRY_DELAY
= ConfigProperty
- .key(METASTORE_PREFIX + ".connect.retry.delay")
+ public static final ConfigProperty<Integer>
META_SERVER_CONNECTION_RETRY_DELAY = ConfigProperty
+ .key(META_SERVER_PREFIX + ".connect.retry.delay")
.defaultValue(1)
.withDocumentation("Number of seconds for the client to wait between
consecutive connection attempts");
- public static HoodieMetastoreConfig.Builder newBuilder() {
- return new HoodieMetastoreConfig.Builder();
+ public static HoodieMetaServerConfig.Builder newBuilder() {
+ return new HoodieMetaServerConfig.Builder();
}
- public boolean enableMetastore() {
- return getBoolean(METASTORE_ENABLE);
+ public boolean enableMetaServer() {
Review Comment:
fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
