minihippo commented on code in PR #5064: URL: https://github.com/apache/hudi/pull/5064#discussion_r1038001088
########## hudi-platform-service/hudi-metaserver/src/main/java/org/apache/hudi/metaserver/client/HoodieMetaserverClientProxy.java: ########## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.metaserver.client; + +import org.apache.hudi.common.config.HoodieMetaserverConfig; + +import java.io.Serializable; +import java.lang.reflect.InvocationHandler; +import java.lang.reflect.InvocationTargetException; +import java.lang.reflect.Method; +import java.lang.reflect.Proxy; +import java.lang.reflect.UndeclaredThrowableException; + +/** + * AOP for meta server client. + */ +public class HoodieMetaserverClientProxy implements InvocationHandler, Serializable { + + private final HoodieMetaserverClient client; + private final int retryLimit; + private final int retryDelaySeconds; + + private HoodieMetaserverClientProxy(HoodieMetaserverConfig config) { + this.retryLimit = config.getConnectionRetryLimit(); + this.retryDelaySeconds = config.getConnectionRetryDelay(); + this.client = new HoodieMetaserverClientImp(config); + } + + public static HoodieMetaserverClient getProxy(HoodieMetaserverConfig config) { + HoodieMetaserverClientProxy handler = new HoodieMetaserverClientProxy(config); + return (HoodieMetaserverClient) Proxy.newProxyInstance(HoodieMetaserverClientProxy.class.getClassLoader(), + new Class[]{HoodieMetaserverClient.class}, handler); + } + + @Override + public Object invoke(Object proxy, Method method, Object[] args) throws Throwable { + int retry = 0; + Throwable err; + do { + try { + return method.invoke(client, args); + } catch (IllegalAccessException | InvocationTargetException | UndeclaredThrowableException e) { + throw e.getCause(); + } catch (Throwable e) { + err = e; + } + retry++; + if (retry >= retryLimit) { + throw err; + } + Thread.sleep(retryDelaySeconds * 1000L); + } while (true); Review Comment: will fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
