alexeykudinkin commented on code in PR #7395:
URL: https://github.com/apache/hudi/pull/7395#discussion_r1042847867
##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/payload/ExpressionPayload.scala:
##########
@@ -242,11 +287,12 @@ class ExpressionPayload(record: GenericRecord,
*
* @return
*/
- private def joinRecord(sourceRecord: IndexedRecord, targetRecord:
IndexedRecord): IndexedRecord = {
+ private def joinRecord(sourceRecord: IndexedRecord, targetRecord:
IndexedRecord): GenericRecord = {
val leftSchema = sourceRecord.getSchema
val joinSchema = getMergedSchema(leftSchema, targetRecord.getSchema)
- val values = new ArrayBuffer[AnyRef]()
+ // TODO rebase onto JoinRecord
Review Comment:
Yeah, leaving these for subsequent follow-up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
