codope commented on code in PR #7395:
URL: https://github.com/apache/hudi/pull/7395#discussion_r1043166522
##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/payload/ExpressionPayload.scala:
##########
@@ -242,11 +287,12 @@ class ExpressionPayload(record: GenericRecord,
*
* @return
*/
- private def joinRecord(sourceRecord: IndexedRecord, targetRecord:
IndexedRecord): IndexedRecord = {
+ private def joinRecord(sourceRecord: IndexedRecord, targetRecord:
IndexedRecord): GenericRecord = {
Review Comment:
Taking `IndexedRecord` as input and returning `GenericRecord` as output. Why
so? Is it because if we later indeed have to deserialize the record then we do
so by name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
