alexeykudinkin commented on code in PR #7035:
URL: https://github.com/apache/hudi/pull/7035#discussion_r1043767016
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -588,6 +588,19 @@ protected void runTableServicesInline(HoodieTable table,
HoodieCommitMetadata me
metadata.addMetadata(HoodieClusteringConfig.SCHEDULE_INLINE_CLUSTERING.key(),
"true");
inlineScheduleClustering(extraMetadata);
}
+
+ // if clustering is disabled, but we might need to rollback any inflight
clustering when clustering was enabled previously.
+ if (!config.inlineClusteringEnabled() &&
!config.isAsyncClusteringEnabled() && !config.scheduleInlineClustering()
Review Comment:
@nsivabalan i do have vague remembrance that we touched upon this prior, so
pardon me for repeating myself if so:
I don't think we should be rolling back any pending clustering after
disabling -- instead we should actually do the following
- Disable just the clustering _planning_ phase when config is flipped
- Predicate clustering execution solely on whether it has a plan -- it
should ignore whether it's enabled or not and only check whether there's a plan
for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
