weimingdiit commented on code in PR #7362:
URL: https://github.com/apache/hudi/pull/7362#discussion_r1051303059
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/BaseSparkCommitActionExecutor.java:
##########
@@ -419,4 +427,23 @@ public Partitioner getLayoutPartitioner(WorkloadProfile
profile, String layoutPa
protected void
runPrecommitValidators(HoodieWriteMetadata<HoodieData<WriteStatus>>
writeMetadata) {
SparkValidatorUtils.runValidators(config, writeMetadata, context, table,
instantTime);
}
+
+ private int dynamicSampleRecordSize(JavaRDD<HoodieRecord<T>> inputRecords) {
+ int dynamicSampleRecordSize = config.getCopyOnWriteRecordSizeEstimate();
+ long inputRecordsCount = inputRecords.count();
Review Comment:
The RDD appears to have been persisted before count was called.
` JavaRDD<HoodieRecord<T>> inputRDD =
HoodieJavaRDD.getJavaRDD(inputRecords);
if (inputRDD.getStorageLevel() == StorageLevel.NONE()) {
inputRDD.persist(StorageLevel.MEMORY_AND_DISK_SER());
} else {
LOG.info("RDD PreppedRecords was persisted at: " +
inputRDD.getStorageLevel());
}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
