pratyakshsharma commented on a change in pull request #1433:
URL: https://github.com/apache/incubator-hudi/pull/1433#discussion_r426189921
##########
File path:
hudi-spark/src/main/java/org/apache/hudi/keygen/TimestampBasedKeyGenerator.java
##########
@@ -88,6 +86,13 @@ public TimestampBasedKeyGenerator(TypedProperties config) {
@Override
public HoodieKey getKey(GenericRecord record) {
+ String recordKey = getRecordKey(record);
Review comment:
I think this has been historically like this. Even I do not have any
pointers around this. But we can enforce those extending from
SimpleKeyGenerator to do so from KeyGenerator. Will do that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
