pratyakshsharma commented on a change in pull request #1433:
URL: https://github.com/apache/incubator-hudi/pull/1433#discussion_r426715335
##########
File path:
hudi-spark/src/main/java/org/apache/hudi/keygen/TimestampBasedKeyGenerator.java
##########
@@ -88,6 +86,13 @@ public TimestampBasedKeyGenerator(TypedProperties config) {
@Override
public HoodieKey getKey(GenericRecord record) {
+ String recordKey = getRecordKey(record);
Review comment:
@nsivabalan actually TimestampBasedKeyGenerator extending
SimpleKeyGenerator has been there historically. I agree with your point, if you
wish, I can refactor the code.
Let me actually go ahead and do it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
