minihippo commented on code in PR #5064: URL: https://github.com/apache/hudi/pull/5064#discussion_r1083142901
########## hudi-platform-service/hudi-metaserver/hudi-metaserver-client/src/main/java/org/apache/hudi/common/table/HoodieTableMetaserverClient.java: ########## @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.common.table; + +import org.apache.hudi.common.config.HoodieMetaserverConfig; +import org.apache.hudi.common.fs.ConsistencyGuardConfig; +import org.apache.hudi.common.fs.FileSystemRetryConfig; +import org.apache.hudi.common.model.HoodieTableType; +import org.apache.hudi.common.table.timeline.HoodieActiveTimeline; +import org.apache.hudi.common.table.timeline.HoodieInstant; +import org.apache.hudi.common.table.timeline.HoodieMetaserverBasedTimeline; +import org.apache.hudi.common.table.timeline.versioning.TimelineLayoutVersion; +import org.apache.hudi.common.util.Option; +import org.apache.hudi.config.HoodieWriteConfig; +import org.apache.hudi.exception.HoodieException; +import org.apache.hudi.metaserver.client.HoodieMetaserverClient; +import org.apache.hudi.metaserver.client.HoodieMetaserverClientProxy; +import org.apache.hudi.metaserver.thrift.NoSuchObjectException; +import org.apache.hudi.metaserver.thrift.Table; + +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.fs.Path; +import org.apache.hadoop.security.UserGroupInformation; +import org.apache.log4j.LogManager; +import org.apache.log4j.Logger; + +import java.io.IOException; +import java.util.List; +import java.util.Set; + +import static org.apache.hudi.common.util.StringUtils.nonEmpty; +import static org.apache.hudi.common.util.ValidationUtils.checkArgument; + +/** + * HoodieTableMetaClient implementation for hoodie table whose metadata is stored in the hoodie metaserver. + */ +public class HoodieTableMetaserverClient extends HoodieTableMetaClient { + private static final Logger LOG = LogManager.getLogger(HoodieTableMetaserverClient.class); + + private final String databaseName; + private final String tableName; + private final Table table; + private final HoodieMetaserverClient metaserverClient; + + public HoodieTableMetaserverClient(Configuration conf, ConsistencyGuardConfig consistencyGuardConfig, + String mergerStrategy, FileSystemRetryConfig fileSystemRetryConfig, + String databaseName, String tableName, HoodieMetaserverConfig config) { + super(conf, config.getString(HoodieWriteConfig.BASE_PATH), false, consistencyGuardConfig, Option.of(TimelineLayoutVersion.CURR_LAYOUT_VERSION), + config.getString(HoodieTableConfig.PAYLOAD_CLASS_NAME), mergerStrategy, fileSystemRetryConfig); + checkArgument(nonEmpty(databaseName), "database name is required."); + checkArgument(nonEmpty(tableName), "table name is required."); + this.databaseName = databaseName; + this.tableName = tableName; + this.metaserverConfig = config; + this.metaserverClient = HoodieMetaserverClientProxy.getProxy(config); + this.table = initOrGetTable(databaseName, tableName, config); + // TODO: transfer table parameters to table config + this.tableConfig = new HoodieTableConfig(); + tableConfig.setTableVersion(HoodieTableVersion.current()); + tableConfig.setAll(config.getProps()); + } + + private Table initOrGetTable(String db, String tb, HoodieMetaserverConfig config) { + Table table; + try { + table = metaserverClient.getTable(databaseName, tableName); + } catch (HoodieException e) { + if (e.getCause() instanceof NoSuchObjectException) { + String user = ""; + try { + user = UserGroupInformation.getCurrentUser().getShortUserName(); + } catch (IOException ioException) { + LOG.info("Failed to get the user", ioException); + } + LOG.info(String.format("Table %s.%s doesn't exist, will create it.", db, tb)); + table = new Table(); + table.setDbName(db); Review Comment: fix ########## hudi-platform-service/hudi-metaserver/hudi-metaserver-server/src/main/java/org/apache/hudi/metaserver/service/HoodieMetaserverService.java: ########## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.metaserver.service; + +import org.apache.hudi.metaserver.thrift.HoodieInstantChangeResult; +import org.apache.hudi.metaserver.thrift.THoodieInstant; +import org.apache.hudi.metaserver.thrift.Table; +import org.apache.hudi.metaserver.thrift.ThriftHoodieMetaserver; +import org.apache.thrift.TException; + +import java.io.Serializable; +import java.nio.ByteBuffer; +import java.util.List; + +/** + * A proxy for meta server, accepts all thrift calls and routes them to the corresponding service. + */ +public class HoodieMetaserverService implements ThriftHoodieMetaserver.Iface, Serializable { Review Comment: fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
