minihippo commented on code in PR #5064: URL: https://github.com/apache/hudi/pull/5064#discussion_r1083145557
########## hudi-platform-service/hudi-metaserver/hudi-metaserver-server/src/main/java/org/apache/hudi/metaserver/store/RelationalDBBasedStorage.java: ########## @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.metaserver.store; + +import org.apache.hudi.metaserver.store.bean.InstantBean; +import org.apache.hudi.metaserver.store.bean.TableBean; +import org.apache.hudi.metaserver.store.jdbc.WrapperDao; +import org.apache.hudi.metaserver.thrift.MetaserverStorageException; +import org.apache.hudi.metaserver.thrift.THoodieInstant; +import org.apache.hudi.metaserver.thrift.TState; +import org.apache.hudi.metaserver.thrift.Table; + +import java.io.Serializable; +import java.text.ParseException; +import java.text.SimpleDateFormat; +import java.util.Collections; +import java.util.Date; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.stream.Collectors; + +import static org.apache.hudi.common.util.CollectionUtils.isNullOrEmpty; +import static org.apache.hudi.common.util.ValidationUtils.checkState; + +/** + * Metadata store based on relation database. + */ +public class RelationalDBBasedStorage implements MetaserverStorage, Serializable { + + private final WrapperDao tableDao = new WrapperDao.TableDao(); + private final WrapperDao timelineDao = new WrapperDao.TimelineDao(); + + @Override + public void initStorage() throws MetaserverStorageException { + WrapperDao dao = new WrapperDao("DDLMapper"); + dao.updateBySql("createDBs", null); + dao.updateBySql("createTables", null); + dao.updateBySql("createTableParams", null); + dao.updateBySql("createPartitions", null); + dao.updateBySql("createTableTimestamp", null); + dao.updateBySql("createInstant", null); + dao.updateBySql("createInstantMetadata", null); + dao.updateBySql("createFiles", null); + } + + @Override + public boolean createDatabase(String db) throws MetaserverStorageException { + Map<String, Object> params = new HashMap<>(); + params.put("databaseName", db); + return tableDao.insertBySql("insertDB", params) == 1; + } + + @Override + public Long getDatabaseId(String db) throws MetaserverStorageException { + List<Long> ids = tableDao.queryForListBySql("selectDBId", db); + validate(ids, "db " + db); + return ids.isEmpty() ? null : ids.get(0); + } + + @Override + public boolean createTable(Long dbId, Table table) throws MetaserverStorageException { + Map<String, Object> params = new HashMap<>(); + params.put("dbId", dbId); + TableBean tableBean = new TableBean(table); + params.put("tableBean", tableBean); + return tableDao.insertBySql("insertTable", params) == 1; + } + + @Override + public Table getTable(String db, String tb) throws MetaserverStorageException { + Map<String, Object> params = new HashMap<>(); + params.put("databaseName", db); + params.put("tableName", tb); + List<TableBean> table = tableDao.queryForListBySql("selectTable", params); + validate(table, "table " + db + "." + tb); + return table.isEmpty() ? null : table.get(0).toTable(); + } + + @Override + public Long getTableId(String db, String tb) throws MetaserverStorageException { + Map<String, Object> params = new HashMap<>(); + params.put("databaseName", db); + params.put("tableName", tb); + List<Long> ids = tableDao.queryForListBySql("selectTableId", params); + validate(ids, "table " + db + "." + tb); + return ids.isEmpty() ? null : ids.get(0); + } + + @Override + public String createNewTimestamp(long tableId) throws MetaserverStorageException { + // todo: support SSS + SimpleDateFormat sdf = new SimpleDateFormat("yyyyMMddHHmmss"); + String oldTimestamp; + String newTimestamp; + boolean success; + try { + do { + oldTimestamp = getLatestTimestamp(tableId); + newTimestamp = oldTimestamp == null + ? sdf.format(new Date()) + : sdf.format(Math.max(new Date().getTime(), sdf.parse(oldTimestamp).getTime() + 1000)); + Map<String, Object> params = new HashMap<>(); + params.put("tableId", tableId); + params.put("oldTimestamp", oldTimestamp); + params.put("newTimestamp", newTimestamp); + if (oldTimestamp == null) { + success = timelineDao.insertBySql("insertTimestamp", params) == 1; + } else { + success = timelineDao.updateBySql("updateTimestamp", params) == 1; + } + } while (!success); + } catch (ParseException e) { + throw new MetaserverStorageException("Fail to parse the timestamp, " + e.getMessage()); + } + return newTimestamp; + } + + private String getLatestTimestamp(long tableId) throws MetaserverStorageException { + List<String> timestamps = timelineDao.queryForListBySql("selectTimestampByTableId", tableId); + validate(timestamps, "timestamp"); + return timestamps.isEmpty() ? null : timestamps.get(0); + } + + @Override + public boolean createInstant(long tableId, THoodieInstant instant) throws MetaserverStorageException { + InstantBean instantBean = new InstantBean(tableId, instant); + Map<String, Object> params = new HashMap<>(); + params.put("instant", instantBean); + // todo: support heartbeat + params.put("duration", 120); + params.put("startTs", (int) (System.currentTimeMillis() / 1000L)); + return timelineDao.insertBySql("insertInstant", params) == 1; + } + + @Override + public boolean updateInstant(long tableId, THoodieInstant fromInstant, THoodieInstant toInstant) throws MetaserverStorageException { + InstantBean oldInstant = new InstantBean(tableId, fromInstant); + InstantBean newInstant = new InstantBean(tableId, toInstant); + Map<String, Object> params = new HashMap<>(); + params.put("oldInstant", oldInstant); + params.put("newInstant", newInstant); + return timelineDao.updateBySql("updateInstant", params) == 1; + } + + @Override + public boolean deleteInstant(long tableId, THoodieInstant instant) throws MetaserverStorageException { + Map<String, Object> params = new HashMap<>(); + params.put("tableId", tableId); + params.put("ts", instant.getTimestamp()); + return timelineDao.deleteBySql("deleteInstant", params) == 1; + } + + @Override + public List<THoodieInstant> scanInstants(long tableId, List<TState> states, int limit) throws MetaserverStorageException { + if (isNullOrEmpty(states)) { + throw new MetaserverStorageException("State has to be specified when scan instants"); + } + Map<String, Object> params = new HashMap<>(); + params.put("tableId", tableId); + params.put("states", states.stream().mapToInt(TState::getValue).boxed().collect(Collectors.toList())); + params.put("limit", limit); + List<InstantBean> instantBeans = timelineDao.queryForListBySql("selectInstantsByStates", params); + return instantBeans.stream().map(InstantBean::toTHoodieInstant).collect(Collectors.toList()); + } + + @Override + public List<THoodieInstant> scanInstants(long tableId, TState state, int limit) throws MetaserverStorageException { + return scanInstants(tableId, Collections.singletonList(state), limit); + } + + @Override + public boolean instantExists(long tableId, THoodieInstant instant) throws MetaserverStorageException { + InstantBean instantBean = new InstantBean(tableId, instant); + List<Long> ids = timelineDao.queryForListBySql("selectInstantId", instantBean); + validate(ids, instantBean.toString()); + return !ids.isEmpty(); + } + + // todo: check correctness + @Override + public void saveInstantMetadata(long tableId, THoodieInstant instant, byte[] metadata) throws MetaserverStorageException { + InstantBean instantBean = new InstantBean(tableId, instant); + Map<String, Object> params = new HashMap<>(); + params.put("instant", instantBean); + params.put("metadata", metadata); + // todo: array bytes to longblob + timelineDao.insertBySql("insertInstantMetadata", params); + } + + @Override + public boolean deleteInstantMetadata(long tableId, THoodieInstant instant) throws MetaserverStorageException { + InstantBean instantBean = new InstantBean(tableId, instant); + return timelineDao.deleteBySql("deleteInstantMetadata", instantBean) == 1; + } + + @Override + public boolean deleteInstantAllMeta(long tableId, String timestamp) throws MetaserverStorageException { + Map<String, Object> params = new HashMap<>(); + params.put("tableId", tableId); + params.put("ts", timestamp); + return timelineDao.deleteBySql("deleteInstantAllMetadata", params) >= 1; + } + + @Override + public byte[] getInstantMetadata(long tableId, THoodieInstant instant) throws MetaserverStorageException { Review Comment: fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
