danny0405 commented on code in PR #7159:
URL: https://github.com/apache/hudi/pull/7159#discussion_r1098158754
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/clustering/plan/strategy/SparkSizeBasedClusteringPlanStrategy.java:
##########
@@ -91,7 +93,7 @@ protected Stream<HoodieClusteringGroup>
buildClusteringGroupsForPartition(String
totalSizeSoFar += currentSize;
}
- if (!currentGroup.isEmpty()) {
+ if (currentGroup.size() > 1 || (writeConfig.isClusteringSortEnabled() &&
currentGroup.size() == 1)) {
Review Comment:
Can we keep the line as is and modify the condition of line91, add the
fileSlice to the currentGroup when necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
