xushiyan commented on code in PR #7914:
URL: https://github.com/apache/hudi/pull/7914#discussion_r1106832148
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/commit/BaseCommitActionExecutor.java:
##########
@@ -246,6 +246,7 @@ protected HoodieWriteMetadata<HoodieData<WriteStatus>>
executeClustering(HoodieC
.performClustering(clusteringPlan, schema, instantTime);
HoodieData<WriteStatus> writeStatusList = writeMetadata.getWriteStatuses();
HoodieData<WriteStatus> statuses = updateIndex(writeStatusList,
writeMetadata);
+ context.putCachedDataIds(config.getBasePath(), instantTime,
statuses.getId());
Review Comment:
i wasn't happy with tracing every persisting call and thought about this
approach but also wanted to keep the impacting scope narrow. A change in all
persist() call may lead to unexpected side effects. Also looks a bit weird to
have a HoodieData to know about any HoodieEngineContext. Having
HoodieEngineContext tracing all HoodieData from it's born and auto-cache its id
makes more sense but it's a much bigger change wrt this PR's intention
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
