alexeykudinkin commented on code in PR #7914:
URL: https://github.com/apache/hudi/pull/7914#discussion_r1107408876
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/commit/BaseCommitActionExecutor.java:
##########
@@ -246,6 +246,7 @@ protected HoodieWriteMetadata<HoodieData<WriteStatus>>
executeClustering(HoodieC
.performClustering(clusteringPlan, schema, instantTime);
HoodieData<WriteStatus> writeStatusList = writeMetadata.getWriteStatuses();
HoodieData<WriteStatus> statuses = updateIndex(writeStatusList,
writeMetadata);
+ context.putCachedDataIds(config.getBasePath(), instantTime,
statuses.getId());
Review Comment:
HoodieData is already tightly coupled (1:1) with HoodieEngineContext so
there's nothing shady about HD API accepting HEC.
Current approach doesn't really make sense as it's extremely brittle -- we
can't expect that someone will be aware of needing to register the RDD whenever
they persist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
