nsivabalan commented on code in PR #7901:
URL: https://github.com/apache/hudi/pull/7901#discussion_r1114603509
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala:
##########
@@ -121,15 +122,19 @@ object HoodieSparkSqlWriter {
val fs = basePath.getFileSystem(sparkContext.hadoopConfiguration)
tableExists = fs.exists(new Path(basePath,
HoodieTableMetaClient.METAFOLDER_NAME))
var tableConfig = getHoodieTableConfig(sparkContext, path,
hoodieTableConfigOpt)
- val (parameters, hoodieConfig) = mergeParamsAndGetHoodieConfig(optParams,
tableConfig, mode)
- val originKeyGeneratorClassName =
HoodieWriterUtils.getOriginKeyGenerator(parameters)
+ // get initial params and validate configs
+ val initialRawParams = getInitialParams(optParams)
Review Comment:
yes, I too felt that. let me take a look at all of them and fix the naming
properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
