nsivabalan commented on code in PR #7901:
URL: https://github.com/apache/hudi/pull/7901#discussion_r1115179371
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieWriterUtils.scala:
##########
@@ -86,6 +83,20 @@ object HoodieWriterUtils {
hoodieConfig.setDefaultValue(RECONCILE_SCHEMA)
hoodieConfig.setDefaultValue(DROP_PARTITION_COLUMNS)
hoodieConfig.setDefaultValue(KEYGENERATOR_CONSISTENT_LOGICAL_TIMESTAMP_ENABLED)
+ if (isFreshTable) { // only set default values for a fresh table. these
might be used for config validation in subsequent commits and hence
+ // we should not setting defaults. (infer function could result in
setting wrong defaults)
+ hoodieConfig.setDefaultValue(PAYLOAD_CLASS_NAME)
+ hoodieConfig.setDefaultValue(KEYGENERATOR_CLASS_NAME)
Review Comment:
I ran into some issues around precombine and hence left it out. Let me try
to recollect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
