danny0405 commented on code in PR #7997:
URL: https://github.com/apache/hudi/pull/7997#discussion_r1117860492
##########
hudi-common/src/test/java/org/apache/hudi/common/testutils/FileCreateUtils.java:
##########
@@ -101,7 +101,11 @@ public static String markerFileName(String instantTime,
String fileId, IOType io
}
public static String markerFileName(String instantTime, String fileId,
IOType ioType, String fileExtension) {
- return String.format("%s_%s_%s%s%s.%s", fileId, WRITE_TOKEN, instantTime,
fileExtension, HoodieTableMetaClient.MARKER_EXTN, ioType);
+ return markerFileName(instantTime, fileId, ioType, fileExtension,
WRITE_TOKEN);
+ }
+
+ public static String markerFileName(String instantTime, String fileId,
IOType ioType, String fileExtension, String writeToken) {
+ return String.format("%s_%s_%s%s%s.%s", fileId, writeToken, instantTime,
fileExtension, HoodieTableMetaClient.MARKER_EXTN, ioType);
Review Comment:
Usually we do not add logic only for testing purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
