danny0405 commented on code in PR #8232:
URL: https://github.com/apache/hudi/pull/8232#discussion_r1141598861
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/HoodieTimelineArchiver.java:
##########
@@ -474,13 +477,36 @@ private Stream<HoodieInstant>
getCommitInstantsToArchive() throws IOException {
oldestInstantToRetainForClustering.map(instantToRetain ->
HoodieTimeline.compareTimestamps(s.getTimestamp(),
LESSER_THAN, instantToRetain.getTimestamp()))
.orElse(true)
+ ).filter(s ->
+ latestCleanRetainedInstant.map(instant ->
+ compareTimestamps(s.getTimestamp(), LESSER_THAN,
instant))
Review Comment:
I can get the error use case for incremental cleaning, but block the
archiving of instants with cleaning is kind of risky, it is better we fix the
incremental cleaning procedure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
