danny0405 commented on code in PR #8304:
URL: https://github.com/apache/hudi/pull/8304#discussion_r1150174031
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/lock/LockManager.java:
##########
@@ -111,6 +111,7 @@ public void unlock() {
if
(writeConfig.getWriteConcurrencyMode().supportsOptimisticConcurrencyControl()) {
getLockProvider().unlock();
metrics.updateLockHeldTimerMetrics();
+ close();
Review Comment:
We new many txn managers for each fresh new txn, like in all kinds of action
executors, we execute a `beginTransaction` and `endTransaction` for each of the
txn but missing to call the `#close` explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
