danny0405 commented on code in PR #8304:
URL: https://github.com/apache/hudi/pull/8304#discussion_r1150177037
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/lock/LockManager.java:
##########
@@ -111,6 +111,7 @@ public void unlock() {
if
(writeConfig.getWriteConcurrencyMode().supportsOptimisticConcurrencyControl()) {
getLockProvider().unlock();
metrics.updateLockHeldTimerMetrics();
+ close();
Review Comment:
Of course, it depends on whether we want to keep the long live connection or
short live connection, if we fix the code like this patch does, the connection
becomes short lived.
A long lived connection is more risky for connection leaks, we need to care
about the life cycle of the connection, we need to consider resuing the
existing connection, which makes things more complicited and hard to keep
correctness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
