nsivabalan commented on PR #8107: URL: https://github.com/apache/hudi/pull/8107#issuecomment-1488053579
hey @vinothchandar : I thought about not making it a table property, but finding it hard. can you help me if there is a way out. User still has to configure the right key gen class or we auto infer it. So, the table config will hold a key gen class (implr or timestmp, etc) explicitly irrespective of whether auto key gen is enabled or not. As I mentioned elsewhere in this patch(in response to sagar), hudis' key gen class is for both record key generation and partition path generation. So, atleast for partition path generation, users have to configure(we do auto infer in most of the cases, but we still make an entry to our table config) So, if we make the auto key gen a write config, it may not be easy for us to deduce whether the table had previous auto key gen enabled and if the user switches later? only way we can deduce this is to make it a table property. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
