jonvex commented on code in PR #7881:
URL: https://github.com/apache/hudi/pull/7881#discussion_r1156299374
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieCleanConfig.java:
##########
@@ -64,25 +62,20 @@ public class HoodieCleanConfig extends HoodieConfig {
.withDocumentation("Number of commits to retain, without cleaning. This
will be retained for num_of_commits * time_between_commits "
+ "(scheduled). This also directly translates into how much data
retention the table supports for incremental queries.");
- public static final ConfigProperty<String> CLEANER_HOURS_RETAINED =
ConfigProperty.key("hoodie.cleaner.hours.retained")
+ public static final ConfigProperty<String> CLEANER_HOURS_RETAINED =
ConfigProperty
+ .key("hoodie.cleaner.hours.retained")
.defaultValue("24")
.withDocumentation("Number of hours for which commits need to be
retained. This config provides a more flexible option as"
+ "compared to number of commits retained for cleaning service.
Setting this property ensures all the files, but the latest in a file group,"
+ " corresponding to commits with commit times older than the
configured number of hours to be retained are cleaned.");
public static final ConfigProperty<String> CLEANER_POLICY = ConfigProperty
.key("hoodie.cleaner.policy")
- .defaultValue(HoodieCleaningPolicy.KEEP_LATEST_COMMITS.name())
- .withDocumentation("Cleaning policy to be used. The cleaner service
deletes older file slices files to re-claim space."
- + " By default, cleaner spares the file slices written by the last N
commits, determined by " + CLEANER_COMMITS_RETAINED.key()
- + " Long running query plans may often refer to older file slices
and will break if those are cleaned, before the query has had"
- + " a chance to run. So, it is good to make sure that the data is
retained for more than the maximum query execution time");
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
