jonvex commented on code in PR #7881:
URL: https://github.com/apache/hudi/pull/7881#discussion_r1163352137
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -168,23 +168,16 @@ public class HoodieWriteConfig extends HoodieConfig {
public static final ConfigProperty<String> WRITE_EXECUTOR_TYPE =
ConfigProperty
.key("hoodie.write.executor.type")
- .defaultValue(SIMPLE.name())
-
.withValidValues(Arrays.stream(ExecutorType.values()).map(Enum::name).toArray(String[]::new))
- .sinceVersion("0.13.0")
- .withDocumentation("Set executor which orchestrates concurrent producers
and consumers communicating through a message queue."
- + "BOUNDED_IN_MEMORY: Use LinkedBlockingQueue as a bounded in-memory
queue, this queue will use extra lock to balance producers and consumer"
- + "DISRUPTOR: Use disruptor which a lock free message queue as inner
message, this queue may gain better writing performance if lock was the
bottleneck. "
- + "SIMPLE(default): Executor with no inner message queue and no
inner lock. Consuming and writing records from iterator directly. Compared with
BIM and DISRUPTOR, "
- + "this queue has no need for additional memory and cpu resources
due to lock or multithreading, but also lost some benefits such as speed limit.
"
- + "Although DISRUPTOR is still experimental.");
+ .defaultValue(ExecutorType.SIMPLE.name())
+ .withDocumentation(ExecutorType.class)
+ .sinceVersion("0.13.0");
public static final ConfigProperty<String> KEYGENERATOR_TYPE = ConfigProperty
.key("hoodie.datasource.write.keygenerator.type")
.defaultValue(KeyGeneratorType.SIMPLE.name())
- .withDocumentation("Easily configure one the built-in key generators,
instead of specifying the key generator class."
- + "Currently supports SIMPLE, COMPLEX, TIMESTAMP, CUSTOM,
NON_PARTITION, GLOBAL_DELETE. "
- + "**Note** This is being actively worked on. Please use "
- + "`hoodie.datasource.write.keygenerator.class` instead.");
+ .withDocumentation(KeyGeneratorType.class,
Review Comment:
This seems correct to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
