danny0405 commented on code in PR #8102:
URL: https://github.com/apache/hudi/pull/8102#discussion_r1157173346
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableSource.java:
##########
@@ -234,24 +234,18 @@ public String asSummaryString() {
@Override
public Result applyFilters(List<ResolvedExpression> filters) {
- List<ResolvedExpression> callExpressionFilters = filters.stream()
- .filter(ExpressionUtils::isSimpleCallExpression)
- .collect(Collectors.toList());
- this.fileIndex.setFilters(callExpressionFilters);
+ List<ResolvedExpression> simpleFilters =
filterSimpleCallExpression(filters);
+ Tuple2<List<ResolvedExpression>, List<ResolvedExpression>> splitFilters =
+ extractPartitionPredicateList(
+ simpleFilters,
Review Comment:
extractPartitionPredicateList -> splitExpressionsByPartitonPredicate
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableSource.java:
##########
@@ -234,24 +234,18 @@ public String asSummaryString() {
@Override
public Result applyFilters(List<ResolvedExpression> filters) {
- List<ResolvedExpression> callExpressionFilters = filters.stream()
- .filter(ExpressionUtils::isSimpleCallExpression)
- .collect(Collectors.toList());
- this.fileIndex.setFilters(callExpressionFilters);
+ List<ResolvedExpression> simpleFilters =
filterSimpleCallExpression(filters);
+ Tuple2<List<ResolvedExpression>, List<ResolvedExpression>> splitFilters =
+ extractPartitionPredicateList(
+ simpleFilters,
Review Comment:
extractPartitionPredicateList -> splitExpressionsByPartitonFilters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
