danny0405 commented on code in PR #8102:
URL: https://github.com/apache/hudi/pull/8102#discussion_r1157176039
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/ExpressionUtils.java:
##########
@@ -177,4 +183,123 @@ public static Object
getValueFromLiteral(ValueLiteralExpression expr) {
throw new UnsupportedOperationException("Unsupported type: " +
logicalType);
}
}
+
+ public static List<ResolvedExpression>
filterSimpleCallExpression(List<ResolvedExpression> exprs) {
+ return exprs.stream()
+ .filter(ExpressionUtils::isSimpleCallExpression)
+ .collect(Collectors.toList());
+ }
+
+ /**
+ * Extracts partition predicate from filter condition.
+ * Returns partition predicates and non-partition predicates.
+ */
+ public static Tuple2<List<ResolvedExpression>, List<ResolvedExpression>>
extractPartitionPredicateList(
+ List<ResolvedExpression> exprs,
+ List<String> partitionKeys,
+ RowType tableRowType) {
+ if (partitionKeys.isEmpty()) {
+ return Tuple2.of(exprs, Collections.emptyList());
+ } else {
+ List<ResolvedExpression> partitionFilters = new ArrayList<>();
+ List<ResolvedExpression> nonPartitionFilters = new ArrayList<>();
+ int[] partitionIdxMapping =
tableRowType.getFieldNames().stream().mapToInt(partitionKeys::indexOf).toArray();
+ for (ResolvedExpression expr : exprs) {
Review Comment:
Becase
```java
int target = fieldIdxMapping[refExpr.getFieldIndex()];
if (target >= 0) {
```
is kind of confusing.
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/ExpressionUtils.java:
##########
@@ -177,4 +183,123 @@ public static Object
getValueFromLiteral(ValueLiteralExpression expr) {
throw new UnsupportedOperationException("Unsupported type: " +
logicalType);
}
}
+
+ public static List<ResolvedExpression>
filterSimpleCallExpression(List<ResolvedExpression> exprs) {
+ return exprs.stream()
+ .filter(ExpressionUtils::isSimpleCallExpression)
+ .collect(Collectors.toList());
+ }
+
+ /**
+ * Extracts partition predicate from filter condition.
+ * Returns partition predicates and non-partition predicates.
+ */
+ public static Tuple2<List<ResolvedExpression>, List<ResolvedExpression>>
extractPartitionPredicateList(
+ List<ResolvedExpression> exprs,
+ List<String> partitionKeys,
+ RowType tableRowType) {
+ if (partitionKeys.isEmpty()) {
+ return Tuple2.of(exprs, Collections.emptyList());
+ } else {
+ List<ResolvedExpression> partitionFilters = new ArrayList<>();
+ List<ResolvedExpression> nonPartitionFilters = new ArrayList<>();
+ int[] partitionIdxMapping =
tableRowType.getFieldNames().stream().mapToInt(partitionKeys::indexOf).toArray();
+ for (ResolvedExpression expr : exprs) {
Review Comment:
Because
```java
int target = fieldIdxMapping[refExpr.getFieldIndex()];
if (target >= 0) {
```
is kind of confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
