zhuanshenbsj1 commented on code in PR #8394:
URL: https://github.com/apache/hudi/pull/8394#discussion_r1168119189
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/compact/HoodieFlinkCompactor.java:
##########
@@ -314,6 +314,9 @@ private void compact() throws Exception {
.setParallelism(1);
env.execute("flink_hudi_compaction_" + String.join(",",
compactionInstantTimes));
+ if (conf.getBoolean(FlinkOptions.CLEAN_ASYNC_ENABLED) &&
conf.getBoolean(FlinkOptions.CLEAN_OFFLINE_ENABLE)){
+ writeClient.clean();
+ }
Review Comment:
CleanFunction#open only do clean when
OptionsResolver.isInsertOverwrite(conf) is true.
```
@Override
public void open(Configuration parameters) throws Exception {
super.open(parameters);
if (conf.getBoolean(FlinkOptions.CLEAN_ASYNC_ENABLED)) {
this.writeClient = FlinkWriteClients.createWriteClient(conf,
getRuntimeContext());
this.executor =
NonThrownExecutor.builder(LOG).waitForTasksFinish(true).build();
if (OptionsResolver.isInsertOverwrite(conf)) {
String instantTime = HoodieActiveTimeline.createNewInstantTime();
LOG.info(String.format("exec sync clean with instant time %s...",
instantTime));
executor.execute(() -> writeClient.clean(instantTime), "wait for
sync cleaning finish");
}
}
}
```
I think the real cleaning is actually in CompactionCommitSink#doCommit， and
it depends on whether to enable configuration CLEAN_ASYNC_ENABLED.
```
private void doCommit(String instant, Collection<CompactionCommitEvent>
events) throws IOException {
List<WriteStatus> statuses = events.stream()
.map(CompactionCommitEvent::getWriteStatuses)
.flatMap(Collection::stream)
.collect(Collectors.toList());
HoodieCommitMetadata metadata =
CompactHelpers.getInstance().createCompactionMetadata(
table, instant, HoodieListData.eager(statuses),
writeClient.getConfig().getSchema());
// commit the compaction
this.writeClient.commitCompaction(instant, metadata, Option.empty());
// Whether to clean up the old log file when compaction
if (!conf.getBoolean(FlinkOptions.CLEAN_ASYNC_ENABLED)) {
this.writeClient.clean();
}
}
```
So I added configuration CLEAN_OFFLINE_ENABLE to distinguish it from
configuration CLEAN_ASYNC_ENABLED.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
