danny0405 commented on code in PR #8394:
URL: https://github.com/apache/hudi/pull/8394#discussion_r1168688393
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableSink.java:
##########
@@ -103,6 +103,8 @@ public SinkRuntimeProvider getSinkRuntimeProvider(Context
context) {
conf.setBoolean(FlinkOptions.COMPACTION_ASYNC_ENABLED, false);
}
return Pipelines.compact(conf, pipeline);
+ } else if (OptionsResolver.isMorTable(conf)) {
+ return Pipelines.dummySink(pipeline);
} else {
Review Comment:
The spark offline compaction Job does not take care of cleaning, could you
make it clrear how user can handle the cleaning when they use the flink
streaming ingestion and spark offline compaction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
