danny0405 commented on code in PR #8496:
URL: https://github.com/apache/hudi/pull/8496#discussion_r1170851945
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -292,6 +292,10 @@ private HoodieWriteConfig createMetadataWriteConfig(
.withInlineCompaction(false)
.withMaxNumDeltaCommitsBeforeCompaction(writeConfig.getMetadataCompactDeltaCommitMax())
.withEnableOptimizedLogBlocksScan(String.valueOf(writeConfig.enableOptimizedLogBlocksScan()))
+ // Compaction on metadata table is used as a barrier for archiving
on main dataset and for validating the
+ // deltacommits having corresponding completed commits. Therefore,
we need to compact all fileslices of all
+ // partitions together requiring UnBoundedCompactionStrategy.
+ .withCompactionStrategy(new UnBoundedCompactionStrategy())
Review Comment:
Okay, by default we have a 500GB target IO upper bound. Can we add a UT for
the write config test of MDT then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
