danny0405 commented on code in PR #8496:
URL: https://github.com/apache/hudi/pull/8496#discussion_r1172356870
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -292,6 +292,10 @@ private HoodieWriteConfig createMetadataWriteConfig(
.withInlineCompaction(false)
.withMaxNumDeltaCommitsBeforeCompaction(writeConfig.getMetadataCompactDeltaCommitMax())
.withEnableOptimizedLogBlocksScan(String.valueOf(writeConfig.enableOptimizedLogBlocksScan()))
+ // Compaction on metadata table is used as a barrier for archiving
on main dataset and for validating the
+ // deltacommits having corresponding completed commits. Therefore,
we need to compact all fileslices of all
+ // partitions together requiring UnBoundedCompactionStrategy.
+ .withCompactionStrategy(new UnBoundedCompactionStrategy())
Review Comment:
A write config test, just in case these options are mis-changed during code
evolving. Never mind, we can address that in separate PR, can you fire a PR to
add a test for MDT write config validation for all these changes you raised
recently?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
