danny0405 commented on code in PR #8394:
URL: https://github.com/apache/hudi/pull/8394#discussion_r1172020216
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/SparkRDDWriteClient.java:
##########
@@ -320,7 +322,9 @@ protected HoodieWriteMetadata<JavaRDD<WriteStatus>>
logCompact(String logCompact
public HoodieWriteMetadata<JavaRDD<WriteStatus>> cluster(String
clusteringInstant, boolean shouldComplete) {
HoodieSparkTable<T> table = HoodieSparkTable.create(config, context);
preWrite(clusteringInstant, WriteOperationType.CLUSTER,
table.getMetaClient());
- return tableServiceClient.cluster(clusteringInstant, shouldComplete);
+ HoodieWriteMetadata<JavaRDD<WriteStatus>> clusteringMetadata =
tableServiceClient.cluster(clusteringInstant, shouldComplete);
+ autoCleanOnCommit();
+ return clusteringMetadata;
Review Comment:
Do not introduce unrelated changes in one patch, if we want to add cleaning
procedure for Spark compaction and cleaning, fire another PR and let's discuss
with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
