danny0405 commented on code in PR #8550:
URL: https://github.com/apache/hudi/pull/8550#discussion_r1174794009
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteOperatorCoordinator.java:
##########
@@ -522,7 +522,10 @@ private boolean commitInstant(String instant, long
checkpointId) {
.flatMap(Collection::stream)
.collect(Collectors.toList());
- if (writeResults.size() == 0) {
+ // Control whether we can commit on empty batch to start a new instant
after each checkpoint
+ boolean allowCommitOnEmptyBatch =
conf.get(FlinkOptions.WRITE_ALLOW_COMMIT_ON_EMPTY_BATCH);
+
+ if (writeResults.size() == 0 && !allowCommitOnEmptyBatch) {
Review Comment:
Overall looks good, just need to note that spark structured streaming
commits the empty instant by default, and there is no chance to turn it off, we
need to consider whether to keep in line with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
