stream2000 commented on code in PR #8550:
URL: https://github.com/apache/hudi/pull/8550#discussion_r1176214461
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteOperatorCoordinator.java:
##########
@@ -522,7 +522,10 @@ private boolean commitInstant(String instant, long
checkpointId) {
.flatMap(Collection::stream)
.collect(Collectors.toList());
- if (writeResults.size() == 0) {
+ // Control whether we can commit on empty batch to start a new instant
after each checkpoint
+ boolean allowCommitOnEmptyBatch =
conf.get(FlinkOptions.WRITE_ALLOW_COMMIT_ON_EMPTY_BATCH);
+
+ if (writeResults.size() == 0 && !allowCommitOnEmptyBatch) {
Review Comment:
I have checked the behavior of spark by running the test `TestEmptyCommit`.
Spark will commit the empty instant by default as expected, and if we turn off
the `hoodie.allow.empty.commit` spark won't commit the commit instant.
What do you think for Flink engine? I think maybe we can keep current
bahavious as default that reuse the instant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
