danny0405 commented on PR #8529: URL: https://github.com/apache/hudi/pull/8529#issuecomment-1522754687
> > @codope Hi codope, I've added a unit test that covers the scenario for AbstractTableFileSystemView, do I still need to add some tests for IncrementalInputSplits? > > @codope Hi codope, WDYT? In `IncrementalInputSplits#filterInstantsByCondition`, we already filtered out the compaction instants that may generate PARQUETs, so there should not be any base file in the filegroup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
