Mulavar commented on PR #8529: URL: https://github.com/apache/hudi/pull/8529#issuecomment-1523235110
> > I agreed with you that IncrementalInputSplits has no error with this patch, and I made a mistake about it. However I'm thinking about whether the logic of this method itself is correct, it should only get log files excluding basefile. If we develop some new features with this method in the future, may this method lead to unexpected results? If not, it's better to close the pr. Sorry for taking up your time, Can you help to confirm this? @danny0405 > > Maybe we can add more document about the premise and usage of the method. as we add some document like "this method is only used for IncrementalInputSplits"? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
