danny0405 commented on code in PR #7355:
URL: https://github.com/apache/hudi/pull/7355#discussion_r1183448153
##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/realtime/HoodieParquetRealtimeInputFormat.java:
##########
@@ -69,6 +69,8 @@ public RecordReader<NullWritable, ArrayWritable>
getRecordReader(final InputSpli
HoodieTableMetaClient metaClient =
HoodieTableMetaClient.builder().setConf(jobConf).setBasePath(realtimeSplit.getBasePath()).build();
HoodieTableConfig tableConfig = metaClient.getTableConfig();
addProjectionToJobConf(realtimeSplit, jobConf,
metaClient.getTableConfig().getPreCombineField());
+ // add partition fields to hive job conf
+ HoodieRealtimeInputFormatUtils.addProjectionField(jobConf,
metaClient.getTableConfig().getPartitionFields());
Review Comment:
Can we reuse like 72?
##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/realtime/HoodieParquetRealtimeInputFormat.java:
##########
@@ -69,6 +69,8 @@ public RecordReader<NullWritable, ArrayWritable>
getRecordReader(final InputSpli
HoodieTableMetaClient metaClient =
HoodieTableMetaClient.builder().setConf(jobConf).setBasePath(realtimeSplit.getBasePath()).build();
HoodieTableConfig tableConfig = metaClient.getTableConfig();
addProjectionToJobConf(realtimeSplit, jobConf,
metaClient.getTableConfig().getPreCombineField());
+ // add partition fields to hive job conf
+ HoodieRealtimeInputFormatUtils.addProjectionField(jobConf,
metaClient.getTableConfig().getPartitionFields());
Review Comment:
Can we reuse line 72?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
