danny0405 commented on code in PR #7355:
URL: https://github.com/apache/hudi/pull/7355#discussion_r1185660019


##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/utils/HoodieRealtimeInputFormatUtils.java:
##########
@@ -96,7 +96,7 @@ public static void addProjectionField(Configuration conf, 
Option<String[]> field
     }
   }
 
-  public static void addRequiredProjectionFields(Configuration configuration, 
Option<HoodieVirtualKeyInfo> hoodieVirtualKeyInfo, Option<String> 
preCombineKeyOpt) {
+  public static void addRequiredProjectionFields(Configuration configuration, 
Option<HoodieVirtualKeyInfo> hoodieVirtualKeyInfo) {
     // Need this to do merge records in HoodieRealtimeRecordReader

Review Comment:
   `addRequiredProjectionFields` -> `addVirtualKeysProjection`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to