nsivabalan commented on code in PR #8107: URL: https://github.com/apache/hudi/pull/8107#discussion_r1185060720
########## hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/keygen/HoodieWrapperKeyGenerator.java: ########## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.hudi.keygen; + +import org.apache.hudi.common.config.TypedProperties; +import org.apache.hudi.common.util.StringUtils; + +import org.apache.avro.generic.GenericRecord; +import org.apache.spark.sql.Row; +import org.apache.spark.sql.catalyst.InternalRow; +import org.apache.spark.sql.types.StructType; +import org.apache.spark.unsafe.types.UTF8String; + +import java.util.List; + +/** + * A wrapper key generator to intercept getRecordKey calls for auto record key generator. + */ +public class HoodieWrapperKeyGenerator extends BuiltinKeyGenerator { + + private final BuiltinKeyGenerator builtinKeyGenerator; + + public HoodieWrapperKeyGenerator(TypedProperties config, BuiltinKeyGenerator builtinKeyGenerator) { + super(config); + this.builtinKeyGenerator = builtinKeyGenerator; + } + + @Override + public String getRecordKey(GenericRecord record) { + if (autoGenerateRecordKeys()) { + return StringUtils.EMPTY_STRING; + } else { Review Comment: Initially I tried moving it out, but we have some validations on record key field present in some of the key gen classes including base class. except for those conditionals, no additional processing is based on autoGenerateRecordKeys(). ########## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/keygen/HoodieWrapperAvroKeyGenerator.java: ########## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.hudi.keygen; + +import org.apache.hudi.common.config.TypedProperties; +import org.apache.hudi.common.util.StringUtils; + +import org.apache.avro.generic.GenericRecord; + +import java.util.List; + +/** + * A wrapper key generator to intercept getRecordKey calls for auto record key generator. + */ +public class HoodieWrapperAvroKeyGenerator extends BaseKeyGenerator { + + private BaseKeyGenerator keyGenerator; + + public HoodieWrapperAvroKeyGenerator(TypedProperties config, BaseKeyGenerator keyGenerator) { + super(config); + this.keyGenerator = keyGenerator; + } + + @Override + public String getRecordKey(GenericRecord record) { + if (autoGenerateRecordKeys()) { + return StringUtils.EMPTY_STRING; Review Comment: same response as above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
