nsivabalan commented on code in PR #8107:
URL: https://github.com/apache/hudi/pull/8107#discussion_r1185062811
##########
hudi-common/src/main/java/org/apache/hudi/keygen/BaseKeyGenerator.java:
##########
@@ -63,10 +67,14 @@ protected BaseKeyGenerator(TypedProperties config) {
*/
@Override
public final HoodieKey getKey(GenericRecord record) {
- if (getRecordKeyFieldNames() == null || getPartitionPathFields() == null) {
+ if (!autoGenerateRecordKeys() && (getRecordKeyFieldNames() == null ||
getPartitionPathFields() == null)) {
throw new HoodieKeyException("Unable to find field names for record key
or partition path in cfg");
}
- return new HoodieKey(getRecordKey(record), getPartitionPath(record));
+ String recordKey = StringUtils.EMPTY_STRING;
+ if (!autoGenerateRecordKeys()) {
Review Comment:
responded for another comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
