rohan-uptycs commented on code in PR #8503:
URL: https://github.com/apache/hudi/pull/8503#discussion_r1185678542
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/index/bucket/HoodieSparkConsistentBucketIndex.java:
##########
@@ -275,4 +280,49 @@ public Option<HoodieRecordLocation>
getRecordLocation(HoodieKey key) {
throw new HoodieIndexException("Failed to getBucket as hashing node has
no file group");
}
}
+
+ /**
+ * Update default metadata file(00000000000000.hashing_meta) with the latest
committed metadata file so that default file will be in sync
+ * with latest commit.
+ *
+ * @param table
+ */
+ public void updateArchivalDependentIndexMetadata(HoodieTable
table,List<HoodieInstant> hoodieArchivalInstants) {
+ Map<String, Boolean> partitionVisiteddMap = new HashMap<>();
+ // Update metadata for replace commit which are going to get archived.
+ Stream<HoodieInstant> hoodieListOfReplacedInstants =
hoodieArchivalInstants.stream().filter(instane ->
instane.getAction().equals(REPLACE_COMMIT_ACTION));
+ hoodieListOfReplacedInstants.forEach(instant -> {
+ Option<Pair<HoodieInstant, HoodieClusteringPlan>> instantPlanPair =
+ ClusteringUtils.getClusteringPlan(table.getMetaClient(),
HoodieTimeline.getReplaceCommitRequestedInstant(instant.getTimestamp()));
+ if (instantPlanPair.isPresent()) {
+ HoodieClusteringPlan plan = instantPlanPair.get().getRight();
+ List<Map<String, String>> partitionMapList =
plan.getInputGroups().stream().map(HoodieClusteringGroup::getExtraMetadata).collect(Collectors.toList());
+ partitionMapList.stream().forEach(partitionMap -> {
+ String partition =
partitionMap.get(SparkConsistentBucketClusteringPlanStrategy.METADATA_PARTITION_KEY);
+ if (!partitionVisiteddMap.containsKey(partition)) {
+ Option<HoodieConsistentHashingMetadata>
hoodieConsistentHashingMetadataOption = loadMetadata(table, partition);
+ if (hoodieConsistentHashingMetadataOption.isPresent()) {
Review Comment:
@danny0405 @SteNicholas modified the approach.
Creating commit marker file for completed clustering operation post commit.
Reader will use commit marker as indicator to get latest metadata for
consistent hashing.
If commit marker fails post commit, there is recovery job which will decide
if its a valid latest metadata and create the marker file.
Please review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
