rohan-uptycs commented on code in PR #8503:
URL: https://github.com/apache/hudi/pull/8503#discussion_r1186796503
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/HoodieIndex.java:
##########
@@ -154,6 +154,14 @@ public boolean requiresTagging(WriteOperationType
operationType) {
public void close() {
}
+ /***
+ * Updates index metadata of the given table and instant if needed.
+ * @param table The committed table.
+ * @param hoodieInstant The instant to commit.
+ */
+ public void commitIndexMetadataIfNeeded(HoodieTable table, String
hoodieInstant) {
+ }
+
Review Comment:
Yeah in updateLocation itself we can't ensure atomicity of clustering
operation.
In UpdateLocation we are already creating metadata through (saveMetadata),
we can treat that metadata as in-flight metadata, and loadMetadata will decide
if that metadata can be committed or not. I think we can use this mechanism to
ensure consistency of metadata.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
