clownxc commented on code in PR #8659:
URL: https://github.com/apache/hudi/pull/8659#discussion_r1188004776
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieInstantTimeGenerator.java:
##########
@@ -129,7 +129,7 @@ public static String getInstantForDateString(String
dateString) {
}
private static TemporalAccessor convertDateToTemporalAccessor(Date d) {
- return d.toInstant().atZone(ZoneId.systemDefault()).toLocalDateTime();
+ return d.toInstant().atZone(getZoneId()).toLocalDateTime();
}
Review Comment:
> convertDateToTemporalAccessor
I added two UTs: `testFormatDateWithCommitTimeZone` and
`testInstantDateParsingWithCommitTimeZone`,
`testInstantDateParsingWithCommitTimeZone` is used to test the correctness of
the `HoodieInstantTimeGenerator#convertDateToTemporalAccessor()` via
`formatDate()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
