clownxc commented on code in PR #8659:
URL: https://github.com/apache/hudi/pull/8659#discussion_r1188006365
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieInstantTimeGenerator.java:
##########
@@ -129,7 +129,7 @@ public static String getInstantForDateString(String
dateString) {
}
private static TemporalAccessor convertDateToTemporalAccessor(Date d) {
- return d.toInstant().atZone(ZoneId.systemDefault()).toLocalDateTime();
+ return d.toInstant().atZone(getZoneId()).toLocalDateTime();
}
Review Comment:
> Can we supplement some UTs for `parseDateFromInstantTime` and
`convertDateToTemporalAccessor` ?
And in the TestHoodieActiveTimeline.java, there are many UTs related to
DateParsing, such as:
- `testInvalidInstantDateParsing`
- `testMillisGranularityInstantDateParsing`
etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
