xushiyan commented on code in PR #6176:
URL: https://github.com/apache/hudi/pull/6176#discussion_r1188065742
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/S3EventsHoodieIncrSource.java:
##########
@@ -189,33 +194,36 @@ public Pair<Option<Dataset<Row>>, String>
fetchNextBatch(Option<String> lastCkpt
.filter(filter)
.select("s3.bucket.name", "s3.object.key")
.distinct()
- .mapPartitions((MapPartitionsFunction<Row, String>) fileListIterator
-> {
+ .rdd()
+ // JavaRDD simplifies coding with collect and suitable mapPartitions
signature. check if this can be avoided.
+ .toJavaRDD()
+ .mapPartitions(fileListIterator -> {
Review Comment:
we usually prefer high level dataframe apis. how is it actually beneficial
to convert to rdd here? don't quite get the comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
