xushiyan commented on code in PR #6176: URL: https://github.com/apache/hudi/pull/6176#discussion_r1188069077
########## hudi-common/src/test/java/org/apache/hudi/common/testutils/S3EventTestPayload.java: ########## @@ -0,0 +1,53 @@ +package org.apache.hudi.common.testutils; + +import org.apache.hudi.avro.MercifulJsonConverter; +import org.apache.hudi.common.model.HoodieRecordPayload; +import org.apache.hudi.common.util.Option; + +import org.apache.avro.Schema; +import org.apache.avro.generic.IndexedRecord; + +import java.io.IOException; +import java.util.Map; + +/** + * Test payload for S3 event here (https://docs.aws.amazon.com/AmazonS3/latest/userguide/notification-content-structure.html). + */ +public class S3EventTestPayload extends GenericTestPayload implements HoodieRecordPayload<S3EventTestPayload> { Review Comment: I'd suggest just test with DefaultHoodieRecordPayload with a specific S3 event schema, instead of creating a new test payload, as we want to test as close as the real scenario. Besides, we don't couple payload with schema, as payload is just responsible for how to merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
