clownxc commented on code in PR #8659:
URL: https://github.com/apache/hudi/pull/8659#discussion_r1193244670
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieInstantTimeGenerator.java:
##########
@@ -144,4 +144,10 @@ public static boolean isValidInstantTime(String
instantTime) {
return false;
}
}
+
+ private static ZoneId getZoneId() {
+ return commitTimeZone.equals(HoodieTimelineTimeZone.LOCAL)
+ ? ZoneId.systemDefault()
Review Comment:
> See the discussions we take in: #8631
It seems that there is no good way to get `HoodieTimelineTimeZone` through
`HoodieTableMetaClient` in `HoodieInstantTimeGenerator`, I currently get
`HoodieTimelineTimeZone` by instantiate a `HoodieTableConfig`, can you give me
some advice?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
