danny0405 commented on code in PR #8659:
URL: https://github.com/apache/hudi/pull/8659#discussion_r1193284045
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieInstantTimeGenerator.java:
##########
@@ -144,4 +144,10 @@ public static boolean isValidInstantTime(String
instantTime) {
return false;
}
}
+
+ private static ZoneId getZoneId() {
+ return commitTimeZone.equals(HoodieTimelineTimeZone.LOCAL)
+ ? ZoneId.systemDefault()
Review Comment:
> I currently get HoodieTimelineTimeZone by instantiate a HoodieTableConfig
If no existing table meta client or table config can be reused, we must
instantiate a new one. For `HoodieTableConfig`, usually we fetch a meta client
first then get the config, take
https://github.com/apache/hudi/blob/42b517d9666f5aafe3faa2a153b07d6f7c774dae/hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/StreamerUtil.java#L307
for a reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
