danny0405 commented on code in PR #8711:
URL: https://github.com/apache/hudi/pull/8711#discussion_r1194693331
##########
hudi-flink-datasource/hudi-flink1.13.x/src/main/java/org/apache/hudi/table/format/cow/ParquetSplitReaderUtil.java:
##########
@@ -387,14 +387,20 @@ private static ColumnReader createColumnReader(
GroupType groupType = physicalType.asGroupType();
List<ColumnReader> fieldReaders = new ArrayList<>();
for (int i = 0; i < rowType.getFieldCount(); i++) {
- fieldReaders.add(
- createColumnReader(
- utcTimestamp,
- rowType.getTypeAt(i),
- groupType.getType(i),
- descriptors,
- pages,
- depth + 1));
+ // schema evolution: read the file with a new extended field name.
+ int fieldIndex =
getFieldIndexInPhysicalType(rowType.getFields().get(i).getName(), groupType);
+ if (fieldIndex < 0) {
+ fieldReaders.add(null);
+ } else {
Review Comment:
Can we use mock constant reader for `NULL` constant to avoid the null reader
instead? It is more safe for programming convention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
