voonhous commented on PR #8711: URL: https://github.com/apache/hudi/pull/8711#issuecomment-1549331729
@danny0405 I have applied the changes from the patch as requested. Have also addressed the comments and added more STRUCT schema evolution scenarios in the test. Can you please take a look at it again? Another thing to point out, I modified the test to use a ExecutorService that is able to timeout the closeable iterator. I found that the original implementation of `#checkAnswer()` is not exactly correct. Actual answer is dependent on the size of Expected answer, which can introduce errors. Example: ```txt Correct answer = 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 provided expected = 0, 1, 2, 3, 4, 5, 6, 7, 8 actual result = 0, 1, 2, 3, 4, 5, 6, 7, 8, 11, 12 ``` It will tell you that that the test is correct. If the **actual** size is dependent on **provided expected**, actual result might get truncated and we our test cases will pass, while in actuality, it should fail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
