voonhous commented on code in PR #8752:
URL: https://github.com/apache/hudi/pull/8752#discussion_r1197514595
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java:
##########
@@ -495,6 +498,8 @@ public Pair<SchemaProvider, Pair<String,
JavaRDD<HoodieRecord>>> readFromSource(
.setPartitionMetafileUseBaseFormat(props.getBoolean(HoodieTableConfig.PARTITION_METAFILE_USE_BASE_FORMAT.key(),
HoodieTableConfig.PARTITION_METAFILE_USE_BASE_FORMAT.defaultValue()))
.setShouldDropPartitionColumns(isDropPartitionColumns())
+
.setHiveStylePartitioningEnable(props.getBoolean(HIVE_STYLE_PARTITIONING_ENABLE.key(),
Review Comment:
Nope, not written to `hoodie.properties`. (The contents is how a
`hoodie.properties` file will look like WITHOUT the the changes made in this PR.
```properties
#Properties saved on 2023-05-18T07:48:15.181Z
#Thu May 18 15:48:15 SGT 2023
hoodie.table.precombine.field=timestamp
hoodie.datasource.write.drop.partition.columns=false
hoodie.table.partition.fields=partition_path
hoodie.table.type=COPY_ON_WRITE
hoodie.archivelog.folder=archived
hoodie.table.cdc.enabled=false
hoodie.populate.meta.fields=true
hoodie.partition.metafile.use.base.format=false
hoodie.table.version=5
hoodie.timeline.layout.version=1
hoodie.table.base.file.format=PARQUET
hoodie.table.recordkey.fields=_row_key
hoodie.table.name=hoodie_trips
hoodie.table.keygenerator.class=org.apache.hudi.utilities.deltastreamer.TestHoodieDeltaStreamer$TestGenerator
hoodie.table.checksum=224269229
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
