voonhous commented on PR #8752: URL: https://github.com/apache/hudi/pull/8752#issuecomment-1552793531
> According the the code in HoodieSparkSqlWriter, there are few more config when building HoodieTableConfig. > > https://github.com/apache/hudi/blob/720c9d76c1d281b7a1305a205d195a4f179ce36a/hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala#LL203C13-L203C13 > > I think it's better we can align DeltaSync according to HoodieSparkSqlWriter. > > BTW: totally agree, we should use a unique entrypoint for this HoodieTableConfig builder. Missing configs that are in `HoodieSparkSqlWriter.scala`, but not in `DeltaSync.java`. # In initializeEmptyTable() ``` .setCommitTimezone() .setDatabaseName() .set(timestampKeyGeneratorConfigs) ``` # In readFromSource() ``` .setCDCEnabled() .setCDCSupplementalLoggingMode() .setCommitTimezone() .setDatabaseName() .setPreCombineField() .setRecordKeyFields() .set(timestampKeyGeneratorConfigs) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
