danny0405 commented on code in PR #8716:
URL: https://github.com/apache/hudi/pull/8716#discussion_r1203510212
##########
hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieBaseParquetWriter.java:
##########
@@ -67,6 +89,22 @@ public HoodieBaseParquetWriter(Path file,
this.recordCountForNextSizeCheck = DEFAULT_MINIMUM_RECORD_COUNT_FOR_CHECK;
}
+ protected void handleParquetBloomFilters(ParquetWriter.Builder
parquetWriterbuilder, Configuration hadoopConf) {
+
parquetWriterbuilder.withBloomFilterEnabled(ParquetOutputFormat.getBloomFilterEnabled(hadoopConf));
+ // inspired from
https://github.com/apache/parquet-mr/blob/master/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetOutputFormat.java#L458-L464
+ hadoopConf.forEach(conf -> {
+ String key = conf.getKey();
+ if (key.startsWith(BLOOM_FILTER_ENABLED)) {
+ String column = key.substring(BLOOM_FILTER_ENABLED.length() + 1,
key.length());
+ parquetWriterbuilder.withBloomFilterEnabled(column,
Boolean.valueOf(conf.getValue()));
Review Comment:
The writer should be shared by all the engines, not just Spark, so it is
necessary to add a basic UT for it, we can keep the IT if it makes sense to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
